From 274c9470784119b5f0d972255cedcbbb0d858ed1 Mon Sep 17 00:00:00 2001
From: Malte Finsterwalder <malte@holi.team>
Date: Thu, 14 Sep 2023 09:53:41 +0200
Subject: [PATCH] HOLI-3881 unify server config in tests
---
app/betterplace_test.ts | 56 +++++++++++------------------------------
1 file changed, 14 insertions(+), 42 deletions(-)
diff --git a/app/betterplace_test.ts b/app/betterplace_test.ts
index e2dc89a..8d4450f 100644
--- a/app/betterplace_test.ts
+++ b/app/betterplace_test.ts
@@ -46,6 +46,13 @@ type UrlPrefix = string;
const projectsUrlWithDefaultOptions =
"https://api.betterplace.org/de/api_v4/projects.json?facets=completed%3Afalse%7Cclosed%3Afalse%7Cprohibit_donations%3Afalse&order=rank%3ADESC";
+const noCacheServerConfig = {
+ cacheEnabled: false,
+ port: 0,
+ cacheTtlMsBetterplace: 0,
+ fake: false,
+};
+
const stubFetchByUrlPrefix = (
responses: Record<UrlPrefix, ResponsePayload>,
) => {
@@ -323,12 +330,7 @@ describe("betterplace", () => {
it("correctly parses project list", async () => {
fetchStub = stubFetchByUrlPrefix(validApiResponses);
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProjects(graphQLServer);
assertEquals(result, expectedProjectsResponse);
@@ -360,12 +362,7 @@ describe("betterplace", () => {
new Error("Expected error"),
});
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProjects(graphQLServer);
const project1 = result.data.find((p) => p.id === 1);
@@ -381,12 +378,7 @@ describe("betterplace", () => {
),
});
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProjects(graphQLServer);
const project1 = result.data.find((p) => p.id === 1);
@@ -405,12 +397,7 @@ describe("betterplace", () => {
),
});
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProjects(graphQLServer);
const project1 = result.data.find((p) => p.id === 1);
assertExists(project1);
@@ -443,12 +430,7 @@ describe("betterplace", () => {
it("correctly retrieves a project by ID", async () => {
fetchStub = stubFetchByUrlPrefix(validApiResponses);
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProject(graphQLServer);
assertEquals(result, expectedResult);
@@ -457,12 +439,7 @@ describe("betterplace", () => {
it("correctly extracts language from locale", async () => {
fetchStub = stubFetchByUrlPrefix(validApiResponses);
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProject(graphQLServer, {
"accept-language": "de-DE",
});
@@ -476,12 +453,7 @@ describe("betterplace", () => {
it("uses correct language as default if requested language is not supported", async () => {
fetchStub = stubFetchByUrlPrefix(validApiResponses);
- const graphQLServer = createGraphQLServer({
- cacheEnabled: false,
- port: 0,
- cacheTtlMsBetterplace: 0,
- fake: false,
- });
+ const graphQLServer = createGraphQLServer(noCacheServerConfig);
const result = await queryProject(graphQLServer, {
"accept-language": "es",
});
--
GitLab