From c2f71043034e93eff24c669874f7f8e1087d536f Mon Sep 17 00:00:00 2001
From: joaojramia <joao@holistic.foundation>
Date: Tue, 10 Dec 2024 10:49:47 +0100
Subject: [PATCH] test: disable language check test until there is content in
EN again
---
app/goodnews_test.ts | 43 ++++++++++++++++++++++---------------------
app/server.ts | 4 ++--
2 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/app/goodnews_test.ts b/app/goodnews_test.ts
index 74cf0d3..043daf4 100644
--- a/app/goodnews_test.ts
+++ b/app/goodnews_test.ts
@@ -550,25 +550,26 @@ describe('GoodNews server', () => {
})
})
- it('uses correct language as default if requested language is not supported', () => {
- return withMockedResponses(contentfulConfig, responses, async () => {
- const graphQLServer = createGraphQLServer(config)
- const result = await queryArticles(graphQLServer, {
- 'accept-language': 'es',
- })
-
- assertEquals(result, {
- articles: [
- {
- id: item1_id,
- language: 'en',
- },
- ],
- previousDateTeaser: {
- id: item3_id,
- language: 'en',
- },
- })
- })
- })
+ // TODO: uncomment this once GoodNews is back with English content
+ // it('uses correct language as default if requested language is not supported', () => {
+ // return withMockedResponses(contentfulConfig, responses, async () => {
+ // const graphQLServer = createGraphQLServer(config)
+ // const result = await queryArticles(graphQLServer, {
+ // 'accept-language': 'es',
+ // })
+
+ // assertEquals(result, {
+ // articles: [
+ // {
+ // id: item1_id,
+ // language: 'en',
+ // },
+ // ],
+ // previousDateTeaser: {
+ // id: item3_id,
+ // language: 'en',
+ // },
+ // })
+ // })
+ // })
})
diff --git a/app/server.ts b/app/server.ts
index fc84320..0e575b9 100644
--- a/app/server.ts
+++ b/app/server.ts
@@ -1,4 +1,4 @@
-import { GoodNewsArticleQueryResponse } from './api_types.ts'
+import { GoodNewsArticleQueryResponse, GoodNewsLanguage } from './api_types.ts'
import { createSchema, createYoga, gql, useResponseCache } from './deps.ts'
import { executeArticlesQuery } from './goodnews.ts'
import { logger } from './logging.ts'
@@ -61,7 +61,7 @@ const createResolvers = (config: ContentfulConfig) => {
}
// deno-lint-ignore no-unused-vars
-const getLanguage = (headers?: Headers) => 'de' // temporarily forced to German until GoodNews is back with English content
+const getLanguage = (headers?: Headers) => 'de' as GoodNewsLanguage // temporarily forced to German until GoodNews is back with English content
// TODO: uncomment this once GoodNews is back with English content
// const getLanguage = (headers?: Headers) => {
--
GitLab