From 36ab42a630a204ad3f3863330d518ef7e19f5b44 Mon Sep 17 00:00:00 2001
From: Stephanie Freitag <stephanie.freitag@holi.team>
Date: Mon, 31 Mar 2025 11:38:46 +0200
Subject: [PATCH] NOISSUE: fix volunteering web e2e test
---
core/layouts/DetailsScreen/index.tsx | 4 +++-
e2e/web/tests/needs-staging-test-data/volunteering.spec.ts | 3 +--
.../volunteering/screens/VolunteeringEngagementDetail.tsx | 2 ++
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/core/layouts/DetailsScreen/index.tsx b/core/layouts/DetailsScreen/index.tsx
index 870af182a3..95b11566c6 100644
--- a/core/layouts/DetailsScreen/index.tsx
+++ b/core/layouts/DetailsScreen/index.tsx
@@ -113,7 +113,9 @@ export const DetailsScreen = ({
size="medium"
/>
)}
- <Text size="3xl">{title}</Text>
+ <Text size="3xl" testID="detailview-title">
+ {title}
+ </Text>
</Stack>
<Stack direction="column" gap="xxs" shouldRender={!!infoList}>
diff --git a/e2e/web/tests/needs-staging-test-data/volunteering.spec.ts b/e2e/web/tests/needs-staging-test-data/volunteering.spec.ts
index 09c871f9d2..a44398f6f6 100644
--- a/e2e/web/tests/needs-staging-test-data/volunteering.spec.ts
+++ b/e2e/web/tests/needs-staging-test-data/volunteering.spec.ts
@@ -62,8 +62,7 @@ const testAllowsPagination = async (page: Page) => {
const testDisplaysEngagementDetailsCommon = async (page: Page) => {
await page.waitForSelector(byTestId('volunteering-detailview-container'))
- await page.waitForSelector(byTestId('volunteering-engagement-title'))
- await page.waitForSelector(byTestId('volunteering-engagement-description'))
+ await page.waitForSelector(byTestId('detailview-title'))
}
const testDisplaysEngagementDetails = async (context: BrowserContext, page: Page) => {
diff --git a/holi-apps/volunteering/screens/VolunteeringEngagementDetail.tsx b/holi-apps/volunteering/screens/VolunteeringEngagementDetail.tsx
index cfb1a008fd..5cc105303b 100644
--- a/holi-apps/volunteering/screens/VolunteeringEngagementDetail.tsx
+++ b/holi-apps/volunteering/screens/VolunteeringEngagementDetail.tsx
@@ -98,9 +98,11 @@ export const VolunteeringEngagementDetail = () => {
}
}
}}
+ testID="volunteering-engagement-get-in-touch-btn"
/>
</Stack>
}
+ testID="volunteering-detailview-container"
>
<DetailsScreen
loading={loading}
--
GitLab