From 90396df50913d6a8cce3ce661adf4176401e7cdf Mon Sep 17 00:00:00 2001
From: Stefano Cerelli <stefano.cerelli@holi.team>
Date: Mon, 31 Mar 2025 11:30:17 +0000
Subject: [PATCH] Fix feature flag and see all events padding
---
core/featureFlags/constants.ts | 2 +-
core/screens/act/ActSection.tsx | 3 +--
holi-apps/events/screens/EventList.tsx | 1 +
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/core/featureFlags/constants.ts b/core/featureFlags/constants.ts
index 1f6cd4270d..8aa3ee208c 100644
--- a/core/featureFlags/constants.ts
+++ b/core/featureFlags/constants.ts
@@ -2,6 +2,7 @@ export enum FeatureFlagKey {
DONATIONS = 'DONATIONS', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
GOODNEWS = 'GOODNEWS', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
VOLUNTEERING = 'VOLUNTEERING', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
+ EVENTS = 'EVENTS', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
CHAT = 'CHAT', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
NOTIFICATIONS = 'NOTIFICATIONS', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
STORAGE = 'STORAGE', // multivariate ('on', 'off', 'maintenance') -> FeatureFlagWithMaintenance
@@ -12,6 +13,5 @@ export enum FeatureFlagKey {
POST_TRANSLATION = 'POST_TRANSLATION', // boolean
NEW_HOME_FEED = 'NEW_HOME_FEED', // multivariate ('control', 'test') -> FeatureFlagAB
TASK_CONTACT_CTA = 'TASK_CONTACT_CTA', // boolean
- EVENTS = 'EVENTS', // boolean
CHALLENGES_CAROUSEL = 'CHALLENGES_CAROUSEL', // boolean
}
diff --git a/core/screens/act/ActSection.tsx b/core/screens/act/ActSection.tsx
index 7602512ac5..5b9bc9d2b7 100644
--- a/core/screens/act/ActSection.tsx
+++ b/core/screens/act/ActSection.tsx
@@ -10,7 +10,6 @@ import RecommendedChallenges from '@holi-apps/challenges/components/RecommendedC
import DonationUpdates from '@holi-apps/donations/components/DonationUpdates'
import VolunteeringRecos from '@holi-apps/volunteering/components/VolunteeringRecos'
import EventCarousel from '@holi-apps/events/components/EventCarousel'
-import { useFeatureFlag } from '@holi/core/featureFlags/hooks/useFeatureFlag'
export enum ActSectionType {
VOLUNTEERING = 'VOLUNTEERING',
@@ -24,7 +23,7 @@ export const ActSection = ({ type }: { type: ActSectionType }) => {
const cardWidth = useCardWidth()
const displayVolunteering = useFeatureFlagWithMaintenance(FeatureFlagKey.VOLUNTEERING).isOn
const displayDonations = useFeatureFlagWithMaintenance(FeatureFlagKey.DONATIONS).isOn
- const displayEvents = useFeatureFlag(FeatureFlagKey.EVENTS)
+ const displayEvents = useFeatureFlagWithMaintenance(FeatureFlagKey.EVENTS).isOn
switch (type) {
case ActSectionType.CHALLENGES:
diff --git a/holi-apps/events/screens/EventList.tsx b/holi-apps/events/screens/EventList.tsx
index ca9505b967..d63c65c3df 100644
--- a/holi-apps/events/screens/EventList.tsx
+++ b/holi-apps/events/screens/EventList.tsx
@@ -64,6 +64,7 @@ export const EventList = () => {
return (
<Screen
preset="scroll"
+ padding={{ left: 'sm', right: 'sm' }}
headerOptions={{
headerTitle: () => (
<Text headingLevel="2" size="lg">
--
GitLab